Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom ids for W.asymmetry (#540) #543

Merged
merged 2 commits into from
Aug 8, 2023
Merged

custom ids for W.asymmetry (#540) #543

merged 2 commits into from
Aug 8, 2023

Conversation

jGaboardi
Copy link
Member

This PR resolves #540.

@jGaboardi jGaboardi added bug functionality that: returns invalid, erroneous, or meaningless results; or doesn't work at all. weights labels Aug 7, 2023
@jGaboardi jGaboardi self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #543 (c09b2d3) into main (e743c48) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #543     +/-   ##
=======================================
+ Coverage   79.9%   80.0%   +0.1%     
=======================================
  Files        113     113             
  Lines      13135   13151     +16     
=======================================
+ Hits       10491   10516     +25     
+ Misses      2644    2635      -9
Files Changed Coverage Δ
libpysal/weights/tests/test_weights.py 99.7% <100.0%> (+<0.1%) ⬆️
libpysal/weights/weights.py 83.3% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes

@jGaboardi jGaboardi mentioned this pull request Aug 7, 2023
Closed
martinfleis
martinfleis approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@jGaboardi
Copy link
Member Author

Following #540 (comment) I am going to add some clarifying language to the docstring. I will also add (appropriate) clarifying language to the docstring in the new Graph class.

@jGaboardi
Copy link
Member Author

@martinfleis did you want to re-review for the docstring clarification or are we good for merging?

@jGaboardi jGaboardi mentioned this pull request Aug 8, 2023
Merged
@martinfleis martinfleis merged commit a36bccb into pysal:main Aug 8, 2023
9 checks passed
@jGaboardi jGaboardi deleted the w_id_assym branch August 8, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

@ljwolf ljwolf Awaiting requested review from ljwolf

@knaaptime knaaptime Awaiting requested review from knaaptime

Assignees

@jGaboardi jGaboardi

Labels
bug functionality that: returns invalid, erroneous, or meaningless results; or doesn't work at all. weights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: weights.W.asymmetry does not support custom ids
2 participants
@jGaboardi @martinfleis