Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor cleanups of geographs #559

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

martinfleis
Copy link
Member

  • removing get_neighbors and get_weights which are not needed anymore since we have __getitem__ implemented
  • removing _id2i as it is unnecessary in sorted adjacency (and we don't need to keep anything in sync, yay!)
  • updating indexing to eliminate pandas deprecation warnings
  • fixing from_adjacency test to pass on windows

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #559 (2e69a55) into geographs (8e2697c) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           geographs    #559     +/-   ##
===========================================
+ Coverage       81.1%   81.2%   +0.1%     
===========================================
  Files            127     127             
  Lines          14883   14856     -27     
===========================================
- Hits           12070   12062      -8     
+ Misses          2813    2794     -19     
Files Changed Coverage Δ
libpysal/graph/tests/test_base.py 100.0% <ø> (ø)
libpysal/graph/base.py 95.7% <100.0%> (-0.2%) ⬇️
libpysal/graph/tests/test_builders.py 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

@martinfleis martinfleis merged commit b1dab2e into pysal:geographs Sep 7, 2023
9 checks passed
@martinfleis martinfleis deleted the cleanup branch September 7, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants