Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement higher_order, components via sparse.matrix #577

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

martinfleis
Copy link
Member

Clearing up some to-do's in the graph stuff. higher_order and components (n_components, component_labels) stuff is not yet supported in scipy on sparse arrays so going temporarily via sparse matrix.

I also fixed conversion from sparse when islands are present as I bumped into that in higher_order.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #577 (787de3d) into main (9682163) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #577     +/-   ##
=======================================
+ Coverage   82.3%   82.5%   +0.1%     
=======================================
  Files        129     129             
  Lines      15318   15358     +40     
=======================================
+ Hits       12611   12664     +53     
+ Misses      2707    2694     -13     
Files Coverage Δ
libpysal/graph/_utils.py 88.3% <100.0%> (+0.1%) ⬆️
libpysal/graph/base.py 96.4% <100.0%> (+1.9%) ⬆️
libpysal/graph/tests/test_base.py 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

libpysal/graph/base.py Outdated Show resolved Hide resolved
libpysal/graph/base.py Outdated Show resolved Hide resolved
libpysal/graph/base.py Outdated Show resolved Hide resolved
libpysal/graph/base.py Outdated Show resolved Hide resolved
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
@martinfleis martinfleis merged commit 7cff0f3 into pysal:main Sep 29, 2023
10 checks passed
@martinfleis martinfleis deleted the rls_prep branch September 29, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants