Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid could_be_isomorphic on nx 3.2 #586

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

martinfleis
Copy link
Member

Avoids calling could_be_isomorphic with networkx 3.2 due to networkx/networkx#7038

Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jGaboardi
Copy link
Member

xref #585

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #586 (88630b8) into main (b9b58e3) will increase coverage by 0.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #586     +/-   ##
=======================================
+ Coverage   83.6%   84.0%   +0.3%     
=======================================
  Files        128     128             
  Lines      15051   15054      +3     
=======================================
+ Hits       12590   12642     +52     
+ Misses      2461    2412     -49     
Files Coverage Δ
libpysal/graph/_set_ops.py 94.8% <100.0%> (+0.2%) ⬆️

... and 4 files with indirect coverage changes

@martinfleis martinfleis merged commit 0ea928a into pysal:main Oct 21, 2023
9 of 10 checks passed
@martinfleis martinfleis deleted the isomorph branch October 21, 2023 16:20
@jGaboardi jGaboardi mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants