From 3d191ce7cfd796d070d7424988462c654d8fa96d Mon Sep 17 00:00:00 2001 From: xuanzhi33 <37460139+xuanzhi33@users.noreply.github.com> Date: Wed, 28 Feb 2024 17:36:11 +0800 Subject: [PATCH 1/2] docs: Correct the example for "Starting a server" in the API reference --- src/websockets/legacy/server.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/websockets/legacy/server.py b/src/websockets/legacy/server.py index 0f3c1c15..001d1364 100644 --- a/src/websockets/legacy/server.py +++ b/src/websockets/legacy/server.py @@ -899,7 +899,8 @@ class Serve: server = await serve(...) await stop - await server.close() + server.close() + await server.wait_closed() :func:`serve` can be used as an asynchronous context manager. Then, the server is shut down automatically when exiting the context:: From 88cc834786637b089d3c45c707f4703b81d0d044 Mon Sep 17 00:00:00 2001 From: xuanzhi33 <37460139+xuanzhi33@users.noreply.github.com> Date: Wed, 28 Feb 2024 18:30:01 +0800 Subject: [PATCH 2/2] Update server.rst --- docs/faq/server.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/faq/server.rst b/docs/faq/server.rst index 08b412d3..cba1cd35 100644 --- a/docs/faq/server.rst +++ b/docs/faq/server.rst @@ -300,7 +300,8 @@ Here's how to adapt the example just above:: server = await websockets.serve(echo, "localhost", 8765) await stop - await server.close(close_connections=False) + server.close(close_connections=False) + await server.wait_closed() How do I implement a health check? ----------------------------------