Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more specific asserts in dbm tests. #7786

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Use more specific asserts in dbm tests. #7786

merged 1 commit into from
Jun 19, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 19, 2018 •
edited
Loading

This may help to investigate bpo-33901.

@serhiy-storchaka
Use more specific asserts in dbm tests.
9cedbdf 
This may help to investigate bpo-33901.
vstinner
vstinner approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 22525de into python:master Jun 19, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test-dbm-asserts branch June 19, 2018 10:31
@bedevere-bot
Copy link

GH-7787 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-7788 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2018
@serhiy-storchaka @miss-islington
Use more specific asserts in dbm tests. (pythonGH-7786)
482891a 
This may help to investigate bpo-33901.
(cherry picked from commit 22525de)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2018
@serhiy-storchaka @miss-islington
Use more specific asserts in dbm tests. (pythonGH-7786)
1a953ed 
This may help to investigate bpo-33901.
(cherry picked from commit 22525de)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 22525de737679ace1488e63b7ed289bdb253ffc7 2.7

@serhiy-storchaka serhiy-storchaka removed their assignment Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni