bpo-33720: Refactor marshalling/unmarshalling floats. #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may reduce the stack consumption for unmarshalling deeply nested structures.
serhiy-storchaka
force-pushed
the
marshal-floats-refactoring
branch
from
979d682
to
282cf4f
Compare
methane
approved these changes
Jul 4, 2018
zooba
approved these changes
Jul 4, 2018
|
Unfortunately the goal is not achieved. This change doesn't reduce stack consumption in the PGO build on Windows (which is around 1600 bytes per level, much more than 256 bytes for the buffer). I'm merging this PR in master only just as refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may reduce the stack consumption for unmarshalling deeply
nested structures.
https://bugs.python.org/issue33720