Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings to public methods from context.c #8531

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jul 28, 2018

This PR adds docstrings to the functions from context.c. It essentially just copies the relevant bits from the existing documentation on Context Variables.

(some of the text was adjusted a bit to adhere to the 80 characters limit of the docstring summary line)

@1st1 Please just let me know your final decision on whether or not to create a ticket for this, and I'll update the PR title accordingly if needed, thanks.

@plamut plamut requested a review from 1st1 as a code owner July 28, 2018 15:21
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@plamut
Copy link
Contributor Author

plamut commented Jul 28, 2018

For the record, I just signed the CLA, and we now need to wait one business day for an official confirmation.

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement and removed CLA not signed labels Jul 29, 2018
@1st1 1st1 merged commit 20678fd into python:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants