Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypyc TypedDict tests broken on master by typing_extensions 4.7.0 #15542

Closed
AlexWaygood opened this issue Jun 28, 2023 · 2 comments · Fixed by #15543
Closed

Mypyc TypedDict tests broken on master by typing_extensions 4.7.0 #15542

AlexWaygood opened this issue Jun 28, 2023 · 2 comments · Fixed by #15543
Labels
bug mypy got something wrong topic-mypyc mypyc bugs topic-typed-dict

Comments

@AlexWaygood
Copy link
Member

Our mypyc TypedDict tests are failing on master due to the latest typing_extensions release. You can see in this run that the one job that used typing_extensions 4.7.0 failed, but all the others passed: https://github.com/python/mypy/actions/runs/5405782682

And on this PR, which is using 4.7.0 on all jobs, the mypyc TypedDict tests are failing on all jobs: #15541

Cc. @JelleZijlstra
@AlexWaygood AlexWaygood added the bug mypy got something wrong label Jun 28, 2023
@AlexWaygood AlexWaygood mentioned this issue Jun 28, 2023
Merged
@JelleZijlstra
Copy link
Member

This is quite possibly broken on 3.7 only. When are we dropping 3.7 support?

@AlexWaygood
Copy link
Member Author

This is quite possibly broken on 3.7 only.

Yes, looks like that's probably the case!

@JelleZijlstra JelleZijlstra mentioned this issue Jun 28, 2023
Merged
@AlexWaygood AlexWaygood mentioned this issue Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mypy got something wrong topic-mypyc mypyc bugs topic-typed-dict
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests on 3.7 JelleZijlstra/mypy
2 participants
@JelleZijlstra @AlexWaygood