Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move label_to_label.yml to an issue? #126714

Open
zou3519 opened this issue May 20, 2024 · 3 comments
Open

move label_to_label.yml to an issue? #126714

zou3519 opened this issue May 20, 2024 · 3 comments
Labels
actionable better-engineering Relatively self-contained tasks for better engineering contributors module: devx Related to PyTorch contribution experience (HUD, pytorchbot) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@zou3519
Copy link
Contributor

zou3519 commented May 20, 2024

Today there are rules for adding labels if a label exists already. These are specified in label_to_label.yml. Would it be possible to read this from an issue instead of a checked-in yaml? Reading from the issue has the following benefits:

  • it lets us modify the file without waiting for code review. This is useful to test label configurations (if some of them generate too much noise, then I want to turn them off).
  • it is more discoverable

cc @ZainRizvi @kit1980 @huydhn @clee2000

@janeyx99 janeyx99 added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: devx Related to PyTorch contribution experience (HUD, pytorchbot) better-engineering Relatively self-contained tasks for better engineering contributors labels May 21, 2024
@ZainRizvi
Copy link
Contributor

Hey @zou3519, thinking about this feature idea I see the following pros and cons:

Pros:

  • Speed of adding new labels (which has been needed once in the past month?)

Cons:

  • Higher risk of fat fingering
  • Security concerns (who has access to edit the issue unilaterally?)

Ambiguous:

  • I'm not sure how issues would be more discoverable vs a yaml file. Both would need some pointer to discover, except yaml files might get discovered via vscode or github's global code search.

Overall, I'm not sure if this is a good idea to support especially since this is something that seems like it would rarely be updated.

Personally, I prefer the idea of using issues for changes where:

  • Speed is critical (e.g. every minute without a change causes CI failures for someone)
  • CI job update and read the issue (basically a poor man's database)

Admittedly, historically we may have been a bit too liberal with using issues as per the above ideas

I'm open to different opinions though

@zou3519
Copy link
Contributor Author

zou3519 commented May 28, 2024

I need to update the labels. It is likely that I need to modify them 5-10 times, because if some labels result in too noisy notifications I will remove them from the list. I haven't updated the labels I'm waiting for this issue to be resolved :P.

More seriously -- #24422 gets edited 6 times a month. What's the frequency for which we'd make a cutoff for features like this?

@malfet
Copy link
Contributor

malfet commented May 29, 2024

Nothing at PyTorch is someone elses problem, so @zou3519 if it's really blocking you, just submit a PR against test infra and ask for a review.

I wasn't even aware we have this label-to-label workflow, which probably causes system to sometimes drop labels, as bot and workflow might attempt to do it concurrently.

IMO we should create an umbrella issue/wiki somewhere, that outlines how we want to approach triage automation, as right now we have 4 distinct approaches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable better-engineering Relatively self-contained tasks for better engineering contributors module: devx Related to PyTorch contribution experience (HUD, pytorchbot) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: Cold Storage
Development

No branches or pull requests

4 participants