Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging/windows/cuda101.bat not used anymore? #3617

Closed
fmassa opened this issue Mar 30, 2021 · 1 comment · Fixed by #3618
Closed

packaging/windows/cuda101.bat not used anymore? #3617

fmassa opened this issue Mar 30, 2021 · 1 comment · Fixed by #3618
Labels
module: ci topic: binaries

Comments

@fmassa
Copy link
Member

fmassa commented Mar 30, 2021 •
edited by pytorch-probot bot
Loading

Following #3399 (comment) , looks like packaging/windows/cuda101.bat is not used anymore. If that's indeed the case, we should remove it.

cc @seemethere
@fmassa fmassa mentioned this issue Mar 30, 2021
Merged
@peterjc123
Copy link
Contributor

peterjc123 commented Mar 30, 2021 •
edited
Loading

@fmassa Not just packaging/windows/cuda101.bat. More files could be deleted, including

  • packaging/windows/
    • all scripts & yamls in that dir
    • templates
    • old
  • packaging/conda/
    • all scripts in that dir
  • packaging/windows/internal
    • all scripts except the following
      • cuda_install.bat
      • vc_install_helper.sh
      • vs2017_install.ps1
      • vs2019_install.ps1
      • vc_env_helper.bat
      • build_cmake.bat
      • build_cpp_example.bat
      • build_frcnn.bat

@NicolasHug NicolasHug mentioned this issue Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: ci topic: binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unneeded packaging files NicolasHug/vision
2 participants
@fmassa @peterjc123