You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
➜ reviewbot git:(feat/metric) ✗ gochecknoglobals ./...
/Users/jicarl/qiniu/reviewbot/internal/metric/metrics.go:16:2: WEWORK_WEBHOOK is a global variable
/Users/jicarl/qiniu/reviewbot/internal/metric/metrics.go:20:2: issueCounter is a global variable
/Users/jicarl/qiniu/reviewbot/internal/linters/linters.go:39:2: pullRequestHandlers is a global variable
/Users/jicarl/qiniu/reviewbot/internal/linters/linters.go:40:2: LinterLanguages is a global variable
/Users/jicarl/qiniu/reviewbot/internal/linters/c/cppcheck/cppcheck.go:11:5: linterName is a global variable
/Users/jicarl/qiniu/reviewbot/internal/linters/doc/note-check/note.go:105:2: standardNoteMarker is a global variable
/Users/jicarl/qiniu/reviewbot/internal/linters/doc/note-check/note.go:109:2: nonstandardNoteMarker is a global variable
/Users/jicarl/qiniu/reviewbot/internal/linters/git-flow/commit-check/commit_check.go:212:5: rulers is a global variable
/Users/jicarl/qiniu/reviewbot/internal/linters/go/gofmt/gofmt.go:17:5: lintName is a global variable
/Users/jicarl/qiniu/reviewbot/internal/linters/go/golangci_lint/golangci_lint.go:12:5: lintName is a global variable
/Users/jicarl/qiniu/reviewbot/internal/version/version.go:9:2: defaultVersion is a global variable
/Users/jicarl/qiniu/reviewbot/tools/phony/main.go:34:2: address is a global variable
/Users/jicarl/qiniu/reviewbot/tools/phony/main.go:35:2: hmacS is a global variable
/Users/jicarl/qiniu/reviewbot/tools/phony/main.go:36:2: event is a global variable
/Users/jicarl/qiniu/reviewbot/tools/phony/main.go:37:2: payload is a global variable
错误很多,但有些过于武断了,比如:
包下的私有变量也不允许
flag 用到的变量也不允许
且看起来这个工具有没有相关的能力能针对上述两种情况做筛选。
所以综合考虑下来,决定关闭这个linter。
The text was updated successfully, but these errors were encountered:
使用gochecknogobals 检查reviewbot, 结果如下
错误很多,但有些过于武断了,比如:
且看起来这个工具有没有相关的能力能针对上述两种情况做筛选。
所以综合考虑下来,决定关闭这个linter。
The text was updated successfully, but these errors were encountered: