Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] qmk list-keyboards omits keyboards whose name contains "keymaps" #17467

Closed
precondition opened this issue Jun 24, 2022 · 0 comments
Closed

Comments

@precondition
Copy link
Contributor

Describe the Bug

In lib/python/qmk/keyboard.py, we can see that list-keyboards omits any path containing the word "keymaps":

def list_keyboards():
    """Returns a list of all keyboards.
    """
    # We avoid pathlib here because this is performance critical code.
    kb_wildcard = os.path.join(base_path, "**", "rules.mk")
    paths = [path for path in glob(kb_wildcard, recursive=True) if 'keymaps' not in path]

However, the keyboard naming guidelines do not mention that "keymaps" is somehow a reserved keyword or something.

Demo

~/qmk_firmware/keyboards on develop *3 ⨤6                                                                                                                                                             
❯ mkdir agogo
mkdir: created directory 'agogo'

~/qmk_firmware/keyboards on develop *3 ⨤6                                                                                                                                                             
❯ touch agogo/rules.mk  

~/qmk_firmware/keyboards on develop *3 ⨤7                                                                                                                                                             
❯ qmk list-keyboards | grep agogo
agogo

~/qmk_firmware/keyboards on develop *3 ⨤7                                                                                                                                                             
❯ mv agogo/ keymapsagogo

~/qmk_firmware/keyboards on develop *3 ⨤7                                                                                                                                                             
❯ qmk list-keyboards | grep agogo

~/qmk_firmware/keyboards on develop *3 ⨤7                                                                                                                                                       
❯ mv keymapsagogo keyagogo

~/qmk_firmware/keyboards on develop *3 ⨤6                                                                                                                                                             
❯ qmk list-keyboards | grep agogo
keyagogo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant