Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to coding conventions broken #24037

Closed
thomasa88 opened this issue Jul 3, 2024 · 2 comments
Closed

Links to coding conventions broken #24037

thomasa88 opened this issue Jul 3, 2024 · 2 comments

Comments

@thomasa88
Copy link

thomasa88 commented Jul 3, 2024

Issue Description

Go to the Contribution guidelines at https://github.com/qmk/qmk_firmware/blob/869b7d9ae63f2d5990934f938e44ecfe6d1d9e1f/docs/contributing.md

Try to follow the links to the coding conventions:

404 - page not found
The 869b7d9 branch of qmk_firmware does not contain the path docs/coding_conventions_c.

https://github.com/qmk/qmk_firmware/blob/869b7d9ae63f2d5990934f938e44ecfe6d1d9e1f/docs/coding_conventions_c
https://github.com/qmk/qmk_firmware/blob/869b7d9ae63f2d5990934f938e44ecfe6d1d9e1f/docs/coding_conventions_python

@tzarc
Copy link
Member

tzarc commented Jul 3, 2024

The docs are written to target https://docs.qmk.fm, not through GitHub.
https://docs.qmk.fm/contributing has valid, working links to both pages, for instance.

@thomasa88
Copy link
Author

Oops, my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants