Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] I2C/SPI deficiencies with start/stop and threadsafety #8297

Open
tzarc opened this issue Mar 3, 2020 · 1 comment
Open

[Bug] I2C/SPI deficiencies with start/stop and threadsafety #8297

tzarc opened this issue Mar 3, 2020 · 1 comment
Assignees
@tzarc @KarlK90
Labels
bug core discussion in progress to do

Comments

@tzarc
Copy link
Member

tzarc commented Mar 3, 2020

Describe the Bug

#8173 rolled back #7967 as it caused issues with people invoking start, then transmit, which both acquire the same lock and would deadlock as a result.

Need to go through the current codebase and migrate all i2c usages to start/transmit/stop pattern, and modify the i2c_master under ChibiOS to perform locking only within start/stop.
Should probably remove the address from the transmit API as a result.
@tzarc tzarc self-assigned this Mar 3, 2020
@tzarc
Copy link
Member Author

tzarc commented Feb 28, 2021

Need to perform the same changes for SPI, too.

@tzarc tzarc changed the title [Bug] I2C deficiencies with start/stop and threadsafety [Bug] I2C/SPI deficiencies with start/stop and threadsafety Sep 29, 2021
@JohSchneider JohSchneider mentioned this issue Aug 3, 2022
Closed
14 tasks
@KarlK90 KarlK90 self-assigned this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzarc tzarc

@KarlK90 KarlK90

Labels
bug core discussion in progress to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tzarc @KarlK90