Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using dynamic imports with react-is@16.12.0 #20

Open
nerdstep opened this issue Dec 6, 2019 · 1 comment
Open

Error using dynamic imports with react-is@16.12.0 #20

nerdstep opened this issue Dec 6, 2019 · 1 comment

Comments

@nerdstep
Copy link
Contributor

nerdstep commented Dec 6, 2019

This might be an issue further upstream, but updating to react-is@16.12.0 breaks dynamic imports.

Works fine using 16.11.0:

https://codesandbox.io/s/buttermilk-react-is-11-h2pke

But update to 16.12.0:

https://codesandbox.io/s/buttermilk-react-is-12-zjn9d

And we get the following error:

Error
A React component suspended while rendering, but no fallback UI was specified.

Add a <Suspense fallback=...> component higher in the tree to provide a loading indicator or placeholder to display.
    in Unknown (created by Router)
    in div (created by Router)
    in Router (at src/index.js:11)
    in div (at src/index.js:8)
    in App (at src/index.js:20)
@quantizor
Copy link
Owner

Frustratingly I think it means Suspense has to be extracted from the library and composed by the developer above Buttermilk. I'm having trouble setting up a useful test to verify this though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants