Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Js error when deleting list items with ctrl+backspace #1307

Closed
MichaelTontchev opened this issue Feb 6, 2017 · 4 comments
Closed

Bug: Js error when deleting list items with ctrl+backspace #1307

MichaelTontchev opened this issue Feb 6, 2017 · 4 comments

Comments

@MichaelTontchev
Copy link
Contributor

Steps for Reproduction

  1. Visit quilljs.com
  2. Delete existing text in the quill editor on the main page
  3. Create a bullet list with a single list item (you don't even need text on that item)
  4. Delete with ctrl+backspace (which deletes an entire word)

Expected behavior:
No error, everything is deleted

Actual behavior:
Text is deleted, but error is thrown

image

Platforms:

Windows Server 2012 R2,
Chrome 56 (latest as of writing)

Version:
Whatever the latest version on the website is, but can also repro on my project with version 1.1.10

@jhchen jhchen closed this as completed in d06dde3 Feb 10, 2017
@MichaelTontchev
Copy link
Contributor Author

The commit message for the fix specifies ctrl + backspace is a no-op in Word/Docs. I tried to reproduce this but found ctrl+backspace to behave as generally accepted, which is to delete the previous word, meaning it's not a no-op. Should this issue be reopened?

@jhchen
Copy link
Member

jhchen commented Feb 21, 2017

It was a no-op for me in Word/Docs but maybe it is a Windows vs Mac thing

@jhchen
Copy link
Member

jhchen commented Feb 28, 2017

Had to revert the fix--will look at a more ideal fix for Windows regardless.

@jhchen jhchen reopened this Feb 28, 2017
@MichaelTontchev
Copy link
Contributor Author

Thanks! :)

@jhchen jhchen closed this as completed in e5fe066 Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants