Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat as * as another trigger for bullet lists #1819

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

LFDM
Copy link
Contributor

@LFDM LFDM commented Nov 13, 2017

Taking on #1808, treating * the same as - to trigger a bullet list quicker than going through the toolbar.

@LFDM
Copy link
Contributor Author

LFDM commented Nov 16, 2017

Are these tests flaky somehow? I don't think these changes should have any effect on Safari failing to run...

@jhchen
Copy link
Member

jhchen commented Nov 16, 2017

Yes looks like sauce labs failed to start Safari even with three tries. One stylistic change request: Can you do case '-': case '*': similar to how the checklist works (a few lines above)?

@LFDM LFDM force-pushed the feat/bullet-list-with-asterisk branch from 3c88711 to 76b5424 Compare November 18, 2017 06:43
@LFDM
Copy link
Contributor Author

LFDM commented Nov 18, 2017

Ah yes, sorry - forgot to force push after making these style changes last time. Done now!

@jhchen
Copy link
Member

jhchen commented Nov 18, 2017

Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants