Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep list numbers continuous when separated by certain elements #3086

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

luin
Copy link
Member

@luin luin commented Jul 2, 2020

Currently, blocks (except p and headings) reset inner lists' numbers, which is caused by counter-reset. The intention was to use counter-reset to reset number values to 0 but there's a side effect that can create a new counter.

This change uses counter-set instead to avoid the side effect.

Test plan:
In supported browsers, make sure the list number shows correctly as the following screenshot:
CleanShot 2020-07-03 at 00 20 14@2x

In other browsers, the numbers should not change.

@luin luin marked this pull request as ready for review July 4, 2020 02:48
@luin luin requested a review from jhchen July 4, 2020 02:49
@jhchen jhchen merged commit 586e49a into slab:develop Jul 5, 2020
@jhchen
Copy link
Member

jhchen commented Jul 5, 2020

Merged in 586e49a

@luin luin deleted the counter-set branch August 4, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants