Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested anchor tags after applying multiple link formats. #406

Merged
merged 1 commit into from
Jul 2, 2015

Conversation

yyjhao
Copy link

@yyjhao yyjhao commented Jul 1, 2015

To reproduce the bug: let's say we have text "abc", select "a", apply link "link1", then select "ab", apply link "link2" we will have the following markup: <a href="link2"><a href="link1">a</a>b</a>c. This is malformed url as per html standard, plus quill.getContents() will return text with 2 urls rather than just 1.

@yyjhao
Copy link
Author

yyjhao commented Jul 1, 2015

It seems that the tests are flake - I have done a force push to trigger another round of tests and they fail for different tests.

@willrowe
Copy link
Contributor

willrowe commented Jul 2, 2015

Yeah, the tests tend to timeout a lot and fail for reasons other than the tests not actually passing.

@jhchen
Copy link
Member

jhchen commented Jul 2, 2015

Thanks for the PR! Sorry about the tests. Karma hardcodes a retry of 2 times and travis's connection to saucelabs is very flaky for mobile platforms. If all the other tests pass and the error is just a connectivity error then don't worry about it I'll check and rerun.

jhchen added a commit that referenced this pull request Jul 2, 2015
Fix nested anchor tags after applying multiple link formats.
@jhchen jhchen merged commit ea8e31c into slab:develop Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants