Fix matcher compatibility with RSpec 2 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in 40b7af5 were insufficient, this should do the trick.
jhawthorn
added a commit
that referenced
this pull request
Jan 18, 2015
Fix matcher compatibility with RSpec 2
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up with #156. I was thinking of the other RSpec matcher syntax where you define
failure_message_when_negatedas a method, rather than use it as a DSL call...This way of retaining compatibility with both RSpec 2 & 3 is taken straight from the corresponding file in the
punditgem.