From d7f5ed59e744d566930a390d104c6ff3fb274bf1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Gr=C3=A9lard?= Date: Wed, 6 Mar 2024 14:55:08 +0000 Subject: [PATCH] Use capture phase in `useEscapeKeydown` (#2761) * Use capture phase * Create 75dcd823.yml --- .yarn/versions/75dcd823.yml | 18 ++++++++++++++++++ .../src/useEscapeKeydown.tsx | 4 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 .yarn/versions/75dcd823.yml diff --git a/.yarn/versions/75dcd823.yml b/.yarn/versions/75dcd823.yml new file mode 100644 index 000000000..913ff0980 --- /dev/null +++ b/.yarn/versions/75dcd823.yml @@ -0,0 +1,18 @@ +releases: + "@radix-ui/react-alert-dialog": patch + "@radix-ui/react-context-menu": patch + "@radix-ui/react-dialog": patch + "@radix-ui/react-dismissable-layer": patch + "@radix-ui/react-dropdown-menu": patch + "@radix-ui/react-hover-card": patch + "@radix-ui/react-menu": patch + "@radix-ui/react-menubar": patch + "@radix-ui/react-navigation-menu": patch + "@radix-ui/react-popover": patch + "@radix-ui/react-select": patch + "@radix-ui/react-toast": patch + "@radix-ui/react-tooltip": patch + "@radix-ui/react-use-escape-keydown": patch + +declined: + - primitives diff --git a/packages/react/use-escape-keydown/src/useEscapeKeydown.tsx b/packages/react/use-escape-keydown/src/useEscapeKeydown.tsx index 67f5594a5..58485d5ec 100644 --- a/packages/react/use-escape-keydown/src/useEscapeKeydown.tsx +++ b/packages/react/use-escape-keydown/src/useEscapeKeydown.tsx @@ -16,8 +16,8 @@ function useEscapeKeydown( onEscapeKeyDown(event); } }; - ownerDocument.addEventListener('keydown', handleKeyDown); - return () => ownerDocument.removeEventListener('keydown', handleKeyDown); + ownerDocument.addEventListener('keydown', handleKeyDown, { capture: true }); + return () => ownerDocument.removeEventListener('keydown', handleKeyDown, { capture: true }); }, [onEscapeKeyDown, ownerDocument]); }