Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armv7l-linux support #216

Closed
dillonhafer opened this issue Oct 29, 2022 · 8 comments · Fixed by #218
Closed

armv7l-linux support #216

dillonhafer opened this issue Oct 29, 2022 · 8 comments · Fixed by #218
Labels
enhancement New feature or request

Comments

@dillonhafer
Copy link

No description provided.

@flavorjones
Copy link
Member

Hi, the gem does not currently support this platform, but it looks like we could since the upstream releases a tailwindcss-linux-armv7 binary executable.

I can work on it this week. Can you confirm for me what your platform looks like by responding with the output from gem env? The platform string in particular is the key piece of information I don't currently have.

@flavorjones flavorjones added the enhancement New feature or request label Oct 31, 2022
@flavorjones flavorjones changed the title Does this gem work on armv7l-linux? armv7l-linux support Oct 31, 2022
@dillonhafer
Copy link
Author

dillon@raspberrypi:/var/www/rails-api/current# gem env
RubyGems Environment:
  - RUBYGEMS VERSION: 3.3.7
  - RUBY VERSION: 3.1.2 (2022-04-12 patchlevel 20) [armv7l-linux-eabihf]
  - INSTALLATION DIRECTORY: /home/dillon/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0
  - USER INSTALLATION DIRECTORY: /home/dillon/.local/share/gem/ruby/3.1.0
  - RUBY EXECUTABLE: /home/dillon/.asdf/installs/ruby/3.1.2/bin/ruby
  - GIT EXECUTABLE: /usr/bin/git
  - EXECUTABLE DIRECTORY: /home/dillon/.asdf/installs/ruby/3.1.2/bin
  - SPEC CACHE DIRECTORY: /home/dillon/.local/share/gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: /home/dillon/.asdf/installs/ruby/3.1.2/etc
  - RUBYGEMS PLATFORMS:
     - ruby
     - armv7l-linux-eabihf
  - GEM PATHS:
     - /home/dillon/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0
     - /home/dillon/.local/share/gem/ruby/3.1.0
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :backtrace => false
     - :bulk_threshold => 1000
  - REMOTE SOURCES:
     - https://rubygems.org/
  - SHELL PATH:
     - /home/dillon/.asdf/installs/ruby/3.1.2/bin
     - /home/dillon/.asdf/shims
     - /home/dillon/.asdf/bin
     - /usr/local/sbin
     - /usr/local/bin
     - /usr/sbin
     - /usr/bin
     - /sbin
     - /bin

@dillonhafer
Copy link
Author

dillonhafer commented Oct 31, 2022

Currently, I'm monkey-patching the gem as part of my deploy process by opening the Tailwindcss::Commands module and changing the .executable method to return system("which tailwindcss") to use the system installed CLI

@flavorjones
Copy link
Member

Thanks for the additional info. It should be easy to add this platform, but it may be harder to test it. I'll take a look this week!

@flavorjones
Copy link
Member

I've got a PR at #218 that looks like it works. It should go green shortly, if so I can merge and cut a release tomorrow.

@flavorjones
Copy link
Member

arm-linux support was released in v2.0.17

@dillonhafer
Copy link
Author

Wow, thanks for all your work, I really appreciate the time that went into this. 🎉

@dillonhafer
Copy link
Author

I just ran a deployment and it worked perfectly! Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants