Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case when matching license names #145

Closed
khatkar opened this issue Feb 23, 2023 · 0 comments · Fixed by #147
Closed

Ignore case when matching license names #145

khatkar opened this issue Feb 23, 2023 · 0 comments · Fixed by #147

Comments

@khatkar
Copy link
Contributor

khatkar commented Feb 23, 2023

Does it make sense to match license names ignoring the case?
For the flags --allow-only and --fail-on, currently the user has to provide all case combinations which feels redundant.
For example,

$ pip-licenses
Name      Version   License
PIMS      0.5       BSD-3-clause
protobuf  3.20.1    BSD-3-Clause

Now running pip-licenses --allow-only "BSD-3-Clause" will fail for the pims package.
So the user has to set --allow-only "BSD-3-Clause;BSD-3-clause". If the user maintains a list of allow-only or fail-only licenses as part of their code, long term stability of such code is affected as new case combinations come up. It'd be nice if we can support case-insensitive matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant