-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Secret
, base class of Secret<T>
#310
Comments
I could send a PR if that would help. |
Can you please explain why you need abstractions over that class? The library gives you whatever instances/types you need. What references are you creating? |
After creating the issue I worked over the abstraction I needed, and it is actually a base lease interface. I created as a record, but it is copying data because of the lack of an abstracting in this library. You can see it here: |
@giggio the intent is to not have a untyped abstraction. It is error prone. Cast Exception etc. |
Describe the feature request or question
Create
Secret
, base class ofSecret<T>
(it could also be an interface). It would contain everythingSecret<T>
has, but thepublic TData Data { get; set; }
property.Link to the Vault API Docs that support this feature
N/A
Additional context
There is currently no way to abstract over different
Secret<T>
s. For example, when one creates a credential, you get aSecret<UsernamePasswordCredentials>
, when you renew it, you get aSecret<RenewedLease>
, and we need to create different references, with no way to abstract over them. With an abstract base classe ofSecret
we could do that.The text was updated successfully, but these errors were encountered: