Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha Issues #453

Closed
20 tasks done
nicpottier opened this issue Sep 12, 2019 · 17 comments
Closed
20 tasks done

Alpha Issues #453

nicpottier opened this issue Sep 12, 2019 · 17 comments
Assignees

Comments

@nicpottier
Copy link
Member

nicpottier commented Sep 12, 2019

Just starting a monster issue to track things that need doing:

  • video on homepage needs to be country specific
  • should use block (or config value) for join message
  • use block for engagement page
  • use block for photos title / content
  • use blocks for join steps
  • use block or config for engagement callout on bottom
  • use block or config for opinions header
  • use block or config for join header
  • use block or config for stories header
  • faq page needs max width treatment
  • jobs page needs max width treatment
  • scale font size on index poll, poll page, questions and story titles based on length
  • another go at left angle on homepage
  • change engagement page top to be all time stats
  • engagement stats precalculated (say at midnight) and cached for 24 hours so we never have cache misses
  • search styling
  • search jumping on click
  • search via year / month
  • reduce GIANT circle numbers
  • full theme colors
@norkans7
Copy link
Contributor

I had added the task to precalculate the engagement stats every 6 hours in ae00630 , should I change that 24?

@nicpottier
Copy link
Member Author

Oh nice, hadn't realized that was precaching.. 24 seems plenty if you ask me but no need to change it.

@norkans7
Copy link
Contributor

Just added all time stats in b1073b5

@norkans7
Copy link
Contributor

Added max width in aa149df

@norkans7
Copy link
Contributor

norkans7 commented Sep 13, 2019

Added homepage video config in 13edc26 and 60afdfa

@norkans7
Copy link
Contributor

I think join message can use the existing {{org|config:"join_text"}}

@norkans7
Copy link
Contributor

Reused she existing blocks for join steps and join header in 799535b

@norkans7
Copy link
Contributor

Added photos section config values in a0bfe1b

@norkans7
Copy link
Contributor

Added more description config values for stories header, polls header, engagement header and the footer engagement callout message in fca8f04

@norkans7
Copy link
Contributor

I am not sure if "another go at left angle on homepage" is the oblique clip on the homepage but if it is I think I have it right finally(both desktop and mobile) in d89f8bc

@nicpottier
Copy link
Member Author

Nice, ya I was more talking about the left side of that angle, but I think that's extra credit anyways.

@nicpottier
Copy link
Member Author

Join message is already a config isn't it? Thought I saw it when in there. If you just tweak the font size (just one step down when more than 50 chars) then I think we can merge all this stuff and ship.

@norkans7
Copy link
Contributor

Add font size reduction for longer texts in d847cfa

@norkans7
Copy link
Contributor

Reused the join text in 87fdab8 and fixed the left homepage in 87be52f

@nicpottier
Copy link
Member Author

Is the text in the left box still vertically aligned with the text in the box below?

@norkans7
Copy link
Contributor

Nope, if that is required, then that is broken, I'lll have to work on that again

@norkans7
Copy link
Contributor

That should be addressed too in e324991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants