From 0f77adcfd3e956095500d61e292e7f67c851dbef Mon Sep 17 00:00:00 2001
From: Bradley Dice <bdice@bradleydice.com>
Date: Thu, 16 Jun 2022 11:55:22 -0500
Subject: [PATCH] Take iterators by value in clamp.cu. (#11084)

This PR updates `clamp.cu` to take templated iterator types by value. This aligns the style with the rest of libcudf. See also: https://github.com/rapidsai/cudf/pull/11019#discussion_r892453138

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - David Wendt (https://github.com/davidwendt)
  - Mark Harris (https://github.com/harrism)

URL: https://github.com/rapidsai/cudf/pull/11084
---
 cpp/src/replace/clamp.cu | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/cpp/src/replace/clamp.cu b/cpp/src/replace/clamp.cu
index 73b224b0c99..d8e7447c5dd 100644
--- a/cpp/src/replace/clamp.cu
+++ b/cpp/src/replace/clamp.cu
@@ -81,10 +81,10 @@ std::pair<std::unique_ptr<column>, std::unique_ptr<column>> form_offsets_and_cha
 
 template <typename OptionalScalarIterator, typename ReplaceScalarIterator>
 std::unique_ptr<cudf::column> clamp_string_column(strings_column_view const& input,
-                                                  OptionalScalarIterator const& lo_itr,
-                                                  ReplaceScalarIterator const& lo_replace_itr,
-                                                  OptionalScalarIterator const& hi_itr,
-                                                  ReplaceScalarIterator const& hi_replace_itr,
+                                                  OptionalScalarIterator lo_itr,
+                                                  ReplaceScalarIterator lo_replace_itr,
+                                                  OptionalScalarIterator hi_itr,
+                                                  ReplaceScalarIterator hi_replace_itr,
                                                   rmm::cuda_stream_view stream,
                                                   rmm::mr::device_memory_resource* mr)
 {
@@ -153,10 +153,10 @@ std::unique_ptr<cudf::column> clamp_string_column(strings_column_view const& inp
 template <typename T, typename OptionalScalarIterator, typename ReplaceScalarIterator>
 std::enable_if_t<cudf::is_fixed_width<T>(), std::unique_ptr<cudf::column>> clamper(
   column_view const& input,
-  OptionalScalarIterator const& lo_itr,
-  ReplaceScalarIterator const& lo_replace_itr,
-  OptionalScalarIterator const& hi_itr,
-  ReplaceScalarIterator const& hi_replace_itr,
+  OptionalScalarIterator lo_itr,
+  ReplaceScalarIterator lo_replace_itr,
+  OptionalScalarIterator hi_itr,
+  ReplaceScalarIterator hi_replace_itr,
   rmm::cuda_stream_view stream,
   rmm::mr::device_memory_resource* mr)
 {
@@ -200,10 +200,10 @@ std::enable_if_t<cudf::is_fixed_width<T>(), std::unique_ptr<cudf::column>> clamp
 template <typename T, typename OptionalScalarIterator, typename ReplaceScalarIterator>
 std::enable_if_t<std::is_same_v<T, string_view>, std::unique_ptr<cudf::column>> clamper(
   column_view const& input,
-  OptionalScalarIterator const& lo_itr,
-  ReplaceScalarIterator const& lo_replace_itr,
-  OptionalScalarIterator const& hi_itr,
-  ReplaceScalarIterator const& hi_replace_itr,
+  OptionalScalarIterator lo_itr,
+  ReplaceScalarIterator lo_replace_itr,
+  OptionalScalarIterator hi_itr,
+  ReplaceScalarIterator hi_replace_itr,
   rmm::cuda_stream_view stream,
   rmm::mr::device_memory_resource* mr)
 {
@@ -215,10 +215,10 @@ std::enable_if_t<std::is_same_v<T, string_view>, std::unique_ptr<cudf::column>>
 template <typename T, typename OptionalScalarIterator, typename ReplaceScalarIterator>
 std::unique_ptr<column> clamp(
   column_view const& input,
-  OptionalScalarIterator const& lo_itr,
-  ReplaceScalarIterator const& lo_replace_itr,
-  OptionalScalarIterator const& hi_itr,
-  ReplaceScalarIterator const& hi_replace_itr,
+  OptionalScalarIterator lo_itr,
+  ReplaceScalarIterator lo_replace_itr,
+  OptionalScalarIterator hi_itr,
+  ReplaceScalarIterator hi_replace_itr,
   rmm::cuda_stream_view stream,
   rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource())
 {