From 697d78ac0544ce5bd31deae07626c853b47deeab Mon Sep 17 00:00:00 2001 From: Yunsong Wang Date: Fri, 10 Mar 2023 13:32:28 -0800 Subject: [PATCH] Migrate parquet encoding to use experimental row operators (#12918) Contributes to #11844 This PR migrates parquet encoding to use the experimental `nan_equal` equality check instead of the legacy `equality_compare`. Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - David Wendt (https://github.com/davidwendt) - Nghia Truong (https://github.com/ttnghia) - Divye Gala (https://github.com/divyegala) URL: https://github.com/rapidsai/cudf/pull/12918 --- cpp/src/io/parquet/chunk_dict.cu | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cpp/src/io/parquet/chunk_dict.cu b/cpp/src/io/parquet/chunk_dict.cu index aca9eed1c39..a4d9673e8fa 100644 --- a/cpp/src/io/parquet/chunk_dict.cu +++ b/cpp/src/io/parquet/chunk_dict.cu @@ -18,7 +18,7 @@ #include #include -#include +#include #include @@ -53,7 +53,8 @@ struct equality_functor { __device__ bool operator()(size_type lhs_idx, size_type rhs_idx) { // We don't call this for nulls so this is fine - return equality_compare(col.element(lhs_idx), col.element(rhs_idx)); + auto const equal = cudf::experimental::row::equality::nan_equal_physical_equality_comparator{}; + return equal(col.element(lhs_idx), col.element(rhs_idx)); } };