Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Remove **kwargs in all IO readers and writers #11780

Closed
3 tasks done
galipremsagar opened this issue Sep 27, 2022 · 2 comments · Fixed by #12025
Closed
3 tasks done

[FEA] Remove **kwargs in all IO readers and writers #11780

galipremsagar opened this issue Sep 27, 2022 · 2 comments · Fixed by #12025
Assignees
@galipremsagar
Labels
cuIO cuIO issue feature request New feature or request Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

galipremsagar commented Sep 27, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
We will need to remove usage of **kwargs in all IO readers and writers, having them is leading to problems where we are silently skipping the incorrectly named parameters that users pass. We have removed the usage of kwargs in CSV readers and writers in #11762.

Describe the solution you'd like
Do the same for

  • parquet
  • orc
  • json
@galipremsagar galipremsagar added feature request New feature or request Python Affects Python cuDF API. cuIO cuIO issue labels Sep 27, 2022
@galipremsagar galipremsagar self-assigned this Sep 27, 2022
@galipremsagar galipremsagar changed the title [FEA] Remove **kwargs in all IO readers and writers [FEA] Remove **kwargs in all IO readers and writers Sep 27, 2022
@bdice
Copy link
Contributor

bdice commented Sep 27, 2022

@galipremsagar I started work on this a while back. See here for the branch: branch-22.10...bdice:cudf:io-kwargs

@galipremsagar
Copy link
Contributor Author

@galipremsagar I started work on this a while back. See here for the branch: branch-22.10...bdice:cudf:io-kwargs

I'll build on top of this

@galipremsagar galipremsagar mentioned this issue Oct 11, 2022
Merged
3 tasks
@GregoryKimball GregoryKimball mentioned this issue Oct 21, 2022
Closed
@galipremsagar galipremsagar mentioned this issue Oct 28, 2022
Merged
7 tasks
@rapids-bot rapids-bot bot closed this as completed in d236779 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
cuIO cuIO issue feature request New feature or request Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Reduce/Remove reliance on **kwargs and *args in IO readers & writers galipremsagar/cudf
2 participants
@bdice @galipremsagar