Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] row_lexicographic_comparator only works when left and right are the same table #3207

Closed
trevorsm7 opened this issue Oct 24, 2019 · 1 comment · Fixed by #3218
Closed
Assignees
Labels
bug Something isn't working Needs Triage Need team to review and classify

Comments

@trevorsm7
Copy link
Contributor

Describe the bug
The row_lexicographic_comparator in cudf/table/row_operators.cuh swaps the left and right indices when the column order is descending, but this only works when the same table is used for left and right.

      if (not ascending) {
        thrust::swap(lhs_index, rhs_index);
      }

Expected behavior
The column order should instead determine how the weak ordering returned by the comparator is handled.

@trevorsm7 trevorsm7 added bug Something isn't working Needs Triage Need team to review and classify labels Oct 24, 2019
@trevorsm7
Copy link
Contributor Author

There don't appear to be any tests for row_lexicographic_comparator or for sorted_order (which uses it), so it would be good to add some for verifying this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs Triage Need team to review and classify
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants