Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Java bindings for AST expressions #8773

Closed
jlowe opened this issue Jul 19, 2021 · 2 comments
Closed

[FEA] Java bindings for AST expressions #8773

jlowe opened this issue Jul 19, 2021 · 2 comments
Assignees
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@jlowe
Copy link
Member

jlowe commented Jul 19, 2021

Is your feature request related to a problem? Please describe.
#5494 added AST support for composing and evaluating expressions at runtime, and it would be nice to have Java bindings for this feature.

Describe the solution you'd like
The Java bindings should have a class hierarchy similar to the native AST node types, but ideally not owning the actual underlying native objects directly. This would require the AST nodes to be AutoCloseable and leak-tracked. Instead, the use-case is likely to be one-shot build and use, so it would be easier on the application to have pure JVM classes to build the AST and a separate API to "compile" that into a native AST representation that does need to be closed and leak-tracked.

Describe alternatives you've considered
A thinner, more direct binding could be done, but this puts more burden on the application to avoid leaks and increases the object creation overhead for every node in the tree.

@jlowe jlowe added feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS labels Jul 19, 2021
@jlowe jlowe self-assigned this Jul 19, 2021
@beckernick beckernick added this to the Conditional Joins milestone Jul 23, 2021
@vyasr
Copy link
Contributor

vyasr commented Jul 30, 2021

@jlowe can we close this with #8846?

@jlowe
Copy link
Member Author

jlowe commented Jul 30, 2021

Yes, this was fixed by #8846 and #8888.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

No branches or pull requests

4 participants