Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add nested struct support in serial hash functions #9119

Closed
rwlee opened this issue Aug 25, 2021 · 3 comments
Closed

[FEA] Add nested struct support in serial hash functions #9119

rwlee opened this issue Aug 25, 2021 · 3 comments
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@rwlee
Copy link
Contributor

rwlee commented Aug 25, 2021

Is your feature request related to a problem? Please describe.
Supported nested structs in serial mumur3 and md5 hash functions.

Describe the solution you'd like
Add flattening with struct null pushdown in top level hash functions. Should be straightforward with proper flattening utilities.

Describe alternatives you've considered
Adding struct support as part of the type dispatch, but this approach would require recursion for nested structs. Flattening within that dispatch would also cause issues because the struct parent null pushdown would have to be done per row.

@rwlee rwlee added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS labels Aug 25, 2021
@rwlee rwlee self-assigned this Sep 8, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@GregoryKimball
Copy link
Contributor

I believe this is closed by #11292, please feel free to reopen with an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

No branches or pull requests

3 participants