From 9e58888dace1b11b2cc206b3549965c94f82a745 Mon Sep 17 00:00:00 2001 From: Yunsong Wang Date: Wed, 2 Feb 2022 15:16:34 -0500 Subject: [PATCH 1/2] Fix cuco pair issue in hash join --- cpp/src/join/hash_join.cuh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/join/hash_join.cuh b/cpp/src/join/hash_join.cuh index c2115c3caa4..21bfd8120f7 100644 --- a/cpp/src/join/hash_join.cuh +++ b/cpp/src/join/hash_join.cuh @@ -68,7 +68,7 @@ class make_pair_function { { // Compute the hash value of row `i` auto row_hash_value = remap_sentinel_hash(_hash(i), _empty_key_sentinel); - return cuco::make_pair(std::move(row_hash_value), std::move(i)); + return cuco::make_pair(row_hash_value, i); } private: From 554d57be36e1b5ba5a8400d0cb7a8270c59355e2 Mon Sep 17 00:00:00 2001 From: Yunsong Wang Date: Wed, 2 Feb 2022 16:50:31 -0500 Subject: [PATCH 2/2] make pair with staic cast --- cpp/src/join/mixed_join_semi.cu | 2 +- cpp/src/join/semi_join.cu | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/src/join/mixed_join_semi.cu b/cpp/src/join/mixed_join_semi.cu index f38e653c4a6..e492968b8a6 100644 --- a/cpp/src/join/mixed_join_semi.cu +++ b/cpp/src/join/mixed_join_semi.cu @@ -45,7 +45,7 @@ struct make_pair_function_semi { { // The value is irrelevant since we only ever use the hash map to check for // membership of a particular row index. - return cuco::make_pair(i, 0); + return cuco::make_pair(static_cast(i), 0); } }; diff --git a/cpp/src/join/semi_join.cu b/cpp/src/join/semi_join.cu index 8563a2a3bd3..39fe0b60c8c 100644 --- a/cpp/src/join/semi_join.cu +++ b/cpp/src/join/semi_join.cu @@ -49,7 +49,7 @@ struct make_pair_function { { // The value is irrelevant since we only ever use the hash map to check for // membership of a particular row index. - return cuco::make_pair(i, 0); + return cuco::make_pair(static_cast(i), 0); } };