Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility of pynvjitlink across versions #48

Open
jakirkham opened this issue Jan 17, 2024 · 3 comments
Open

Compatibility of pynvjitlink across versions #48

jakirkham opened this issue Jan 17, 2024 · 3 comments

Comments

@jakirkham
Copy link
Member

What kind of versioning scheme do we intend to use with pynvjitlink?

Do we intended to hold compatibility with major versions? So 1.x.y would be compatible with x increments for new features and y for bug fixes

Or do we intend to keep compatibility only within minor versions? So 1.2.y would be compatible for all y, but 1.3 would break compatibility?

Or do we have a different model of compatibility in mind?

cc @brandon-b-miller @gmarkall

@vyasr
Copy link
Contributor

vyasr commented Jan 18, 2024

We should also think about what exactly constitutes the public API. Do we intend for consumers to use anything other than patch_numba_linker? Do we want to be exposing pynvjitlink.api.NvJitLinker? What about the methods of that class? If we want to make compatibility guarantees we should figure out these questions first.

@jakirkham
Copy link
Member Author

We discussed this offline at length

The conclusion was we would like to use semantic versioning

For now we will keep the 0 based version, but plan to bump it to 1.0.0 in the next release

@gmarkall
Copy link
Contributor

I'm not sure I'd want to declare "the next release will be 1.0.0" as I may have to make some changes in future for a non-RAPIDS use case, and wouldn't want to bump the version to 1.0.0 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants