-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address workflow inconsistencies #118
Comments
I just discovered this (forgot about this issue) over in #177. Not having I think setting Something like this:
(exact details TBD, based on what's in the matrix for the particular workflow) I think that should be a minimally-invasive changes, since as far as I know, we don't use those names in branch protections, but instead use this mechanism: shared-workflows/.github/workflows/pr-builder.yaml Lines 1 to 9 in da626b6
|
Addressing this in #191 (comment) |
Given that #191 has been merged. The following PRs have been created to use the replace
After these are all merged, a second PR will be opened in |
Second shared-workflows PR: #193 |
All the inconsistencies highlighted in this issue so far have been fixed. I will now close the issue. |
There are a lot of inconsistencies in this repository that we should work to address as time permits.
A few that come to mind are:
.yml
and.yaml
extensionsCUDA_VER
for conda vs.ctk
for wheels)wheel-epoch-timestamp
job, whereas conda workflows use agha-tools
script that usesgh
to retrieve the workflow start time)build
job names in conda and wheel workflows are different (build
for conda andwheel-build
for wheels)name
property in thesebuild
jobs are also inconsistent (it's unset for conda workflows, but set for wheel workflows). this leads to visual differences when viewing the workflows in the browser (see screenshot 1 below)script
, whereas the conda workflows usebuild_script
andtest_script
.This is a non-exhaustive list.
We should review the workflows for additional differences.
screenshot 1
The text was updated successfully, but these errors were encountered: