[data][api] implement HudiDataSource
#46273
Open
+188
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
force-pushed
the
add-hudi-datasource
branch
5 times, most recently
from
7bc3894
to
97f9de1
Compare
xushiyan
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
xushiyan
commented
Jun 28, 2024
| ds = ray.data.read_hudi_table(target_table_path) | ||
|
|
||
| assert ds.count() == 5 | ||
| assert ds.schema() is not None |
There was a problem hiding this comment.
gonna add more assertions on the dataset content
xushiyan
commented
Jun 28, 2024
Comment on lines
+17
to
+18
| --extra-index-url https://test.pypi.org/simple | ||
| hudi==0.1.0 |
There was a problem hiding this comment.
this is temporary for this PR to pass. the --extra-index-url will be removed once the official release is out
xushiyan
commented
Jun 28, 2024
| self, | ||
| table_uri: str, | ||
| storage_options: Optional[Dict[str, str]] = None, | ||
| ): |
There was a problem hiding this comment.
would prefer to support column projections and row filtering through additional arguments as follow-up since the feature is not yet supported
@MicroCheck //python:ray/data/tests/test_hudi Signed-off-by: Shiyan Xu <2701446+xushiyan@users.noreply.github.com>
xushiyan
force-pushed
the
add-hudi-datasource
branch
from
97f9de1
to
d4e8af6
Compare
anyscalesam
added
data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Support read from Hudi table into Ray dataset.
Related issue number
Closes #46272
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.