Fix "similar-code" issue in piaplib/lint/clients_check_status.py

[reactive-firewall]

Similar blocks of code found in 3 locations. Consider refactoring.

https://codeclimate.com/github/reactive-firewall/PiAP-python-tools/piaplib/lint/clients_check_status.py#issue_5ab1cda9abcb0b0001000116

[reactive-firewall]

❌ there is a bug in link after a new commit is made, issue can not be found, histories is missing, feature may not be of much use and only pose a security risk.

[reactive-firewall]

will use https://codeclimate.com/github/reactive-firewall/PiAP-python-tools/piaplib/lint/clients_check_status.py instead

[reactive-firewall]

PiAP-python-tools/piaplib/lint/clients_check_status.py

Lines 431 to 435 in 6098e49

	if ip_list_txt is not None and len(ip_list_txt) > 0:
	theResult = html_generator.gen_html_td(
	html_generator.gen_html_ul(ip_list_txt),
	str(u'client_status_ips_{}')
	).format(client)

PiAP-python-tools/piaplib/lint/clients_check_status.py

Lines 400 to 408 in 6098e49

	if mac_list_txt is not None and len(mac_list_txt) > 0:
	theResult = html_generator.gen_html_td(
	str(mac_list_txt[0]),
	str(u'client_status_macs_{}')
	).format(client)
	else:
	theResult = html_generator.gen_html_td(
	html_generator.gen_html_label(u'No IP', html_generator.HTML_LABEL_ROLES[3]),
	str(u'client_status_macs_{}').format(client)

PiAP-python-tools/piaplib/lint/iface_check_status.py

Lines 311 to 319 in 6098e49

	if ip_list_txt is not None and len(ip_list_txt) > 0:
	theResult = html_generator.gen_html_td(
	html_generator.gen_html_ul(ip_list_txt),
	str(u'iface_status_ips_{}').format(iface)
	)
	else:
	theResult = html_generator.gen_html_td(
	html_generator.gen_html_label(u'No IP', html_generator.HTML_LABEL_ROLES[3]),
	str(u'iface_status_ips_{}').format(iface)