Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification: make notifications permanently dismissable #87

Closed
agjohnson opened this issue Aug 7, 2023 · 1 comment
Closed

Notification: make notifications permanently dismissable #87

agjohnson opened this issue Aug 7, 2023 · 1 comment
Labels
Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

When viewing a pull request build, if I dismiss the pull request warning notification then navigate around back to the top level page, I get the notification again. This could be a little annoying to dismiss repeatedly.

Instead, we should probably track this with a cookie and only show the notification if it hasn't been dismissed by the user.
@agjohnson agjohnson added the Improvement Minor improvement to code label Aug 7, 2023
@humitos
Copy link
Member

humitos commented Aug 7, 2023

We are tracking this at #46

@humitos humitos closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humitos @agjohnson