Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist is missing tox.ini #125

Open
mtelka opened this issue Jun 30, 2023 · 4 comments
Open

sdist is missing tox.ini #125

mtelka opened this issue Jun 30, 2023 · 4 comments

Comments

@mtelka
Copy link

mtelka commented Jun 30, 2023

The sdist package at PyPI is missing tox.ini. Please add the missing tox.ini to sdist to make downstream testing easier. Thank you.

@stsewd
Copy link
Member

stsewd commented Jul 5, 2023

Hi, this is an internal dependency of RTD, it's installed only inside our builders. Curious, where you need this package.

@mtelka
Copy link
Author

mtelka commented Dec 14, 2023

I'm packaging readthedocs-sphinx-ext for OpenIndiana and I did it because it was needed as a dependency for some other package. Not sure now which one it was because currently I'm unable to find any such dependency, but definitely it was needed in January 2023 when I packaged it.

Please note that I'm not alone who thinks the readthedocs-sphinx-ext deserves a package.

Thank you.

@stsewd
Copy link
Member

stsewd commented Jan 10, 2024

I've seen other users packaging this extension because it's a dependency on tests for https://github.com/readthedocs/sphinx_rtd_theme.

https://github.com/readthedocs/sphinx_rtd_theme/blob/80de90aecff3365b1f571dedd6b5c349ec0f89cf/tox.ini#L14

@mtelka
Copy link
Author

mtelka commented Jan 10, 2024

Yes, you are right. Thanks for the pointer. I failed to find this dependency because sphinx_rtd_theme is missing tox.ini too so we are not able to detect its test dependencies and list them explicitly. We just rely on implicit readthedocs-sphinx-ext presence on the test host while testing sphinx_rtd_theme. We should change/fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants