Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UX to comunicate warnings on the build page #4226

Closed
stsewd opened this issue Jun 12, 2018 · 2 comments
Closed

Better UX to comunicate warnings on the build page #4226

stsewd opened this issue Jun 12, 2018 · 2 comments
Labels
Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Jun 12, 2018

Details

Some users that report a problem say that the build show no errors, but there are warnings (which contains very useful information to solve the problem). The problem is that those warnings aren't very easy to see.

Possible solutions

We can't identify in a proper way if there is a warning, the status code is 0 for success, and everything else an error. But we can parse the output and search for some keywords like WARNING, warning, etc.

  • Doing this in the server side (an additional field in the db) seems like a little overkill.
  • We can show this only in the client side
    • Highlight the warning keywords only
    • or show a warning symbol (or color) in the command title
@stsewd stsewd added Design Design or UX/UI related Needed: design decision A core team decision is required labels Jun 12, 2018
@agjohnson agjohnson removed the Design Design or UX/UI related label Jun 12, 2018
@humitos
Copy link
Member

humitos commented Jun 12, 2018

Not a real fix but the -W or strict mode option will make these commands to fail. I'm saying that's not a real fix since the user has to activate that option.

Since we are marking the not 0 exit codes with red, I suppose that we could mark any output with the WARNING word (or similar) with yellow from the client.

@humitos
Copy link
Member

humitos commented Oct 31, 2023

We can think more about this issue. If we can figure it out a good "parsing logic" of command output to make reliable, I think we can use the "mark the command with yellow" idea. However, I think the "parsing logic" is the more important thing here.

I'm not considering this for the new build notification system I'm working on. In any case, this new system is considering having different type of notifications: error, warning, tip, etc. Once we have that parsing logic defined, we can trigger a warning notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

3 participants