Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file: make build.tools not required when using build.commands #9280

Closed
humitos opened this issue Jun 1, 2022 · 0 comments · Fixed by #10281
Closed

Config file: make build.tools not required when using build.commands #9280

humitos opened this issue Jun 1, 2022 · 0 comments · Fixed by #10281
Assignees
@benjaoming
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Jun 1, 2022

When using build.commands, it's possible to build documentation without installing any of the tools we support on build.tools as shown in the example using echo "Hola mundo!" > _readthedocs/html/index.html. However, build.tools is required currently when using build.os. We should remove this restriction and make the Config classes code to differentiate legacy over the new pattern by the usage of build.os instead of build.tools.

Context #9150 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaoming benjaoming

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow build.commands without build.tools benjaoming/readthedocs.org
2 participants
@humitos @benjaoming