Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking objects when registering session listeners #6916

Closed
RealmBot opened this issue Jun 4, 2020 · 0 comments · Fixed by #6986
Closed

Leaking objects when registering session listeners #6916

RealmBot opened this issue Jun 4, 2020 · 0 comments · Fixed by #6986
Assignees
@clementetb
Labels
MongoDBRealm This issue is related to the MongoDB Realm Beta T-Bug

Comments

@RealmBot
Copy link
Collaborator

RealmBot commented Jun 4, 2020 •
edited
Loading

Callbacks for progress and connection state listeners holds references to sessions that are not released when removing the listeners. 

This was introduced for connection listeners in https://github.com/realm/realm-java/pull/6884/files#diff-8c785429417eedf1dd260bab03dafcb1R258

but similar issue exist for progress listener.

Address leftover review comment from: https://github.com/realm/realm-java/pull/6884:

We should probably rename the java_syncmanager_class variables as that is no longer accurate
@rorbech rorbech added the MongoDBRealm This issue is related to the MongoDB Realm Beta label Jun 4, 2020
@cmelchior cmelchior added the T-Bug label Jun 5, 2020
@rorbech rorbech mentioned this issue Jun 5, 2020
Closed
@clementetb clementetb linked a pull request Jul 3, 2020 that will close this issue
Leaking objects when registering session listeners #6986
Merged
@RealmBot RealmBot closed this as completed Jul 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clementetb clementetb

Labels
MongoDBRealm This issue is related to the MongoDB Realm Beta T-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Leaking objects when registering session listeners realm/realm-java
4 participants
@cmelchior @clementetb @rorbech @RealmBot