Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds instances are named neptune instance #1094

Closed
f3lang opened this issue Aug 30, 2023 · 2 comments
Closed

rds instances are named neptune instance #1094

f3lang opened this issue Aug 30, 2023 · 2 comments

Comments

@f3lang
Copy link

f3lang commented Aug 30, 2023

when you perform and plan a nuke of an account, rds instances are listed as Neptune instances. This is buried in the fact, that the neptune api may return rds and docdb instances as well.
Can we build a filter into the logic to filter out only actual neptune instances, as this will delete rds instances at the moment even though rds is blacklisted?
https://docs.aws.amazon.com/neptune/latest/userguide/api-instances.html#DescribeDBInstances

@sulabhk
Copy link

sulabhk commented Jan 22, 2024

➕ to the above observation, but this is probably to do with the underlying AWS API and not nuke (or its filters). I keep facing the same issue in that I see RDS instances being referred to as NeptuneInstances in the nuke output log.

@ekristen
Copy link
Collaborator

@f3lang @sulabhk

I've opened ekristen/aws-nuke#301 on what is now the actively managed fork of aws-nuke. I've confirmed your observations by looking at the API docs. I'll try and see about replicating and getting a fix in as soon as possible.


Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants