-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature-request: add "validate" command #1256
Comments
I've really tried to not directly link to my fork, but in this case try it out - https://github.com/ekristen/aws-nuke - https://ekristen.github.io/aws-nuke/cli-usage/#aws-nuke-explain-config However I don't have a validate per-say, it's an explain configuration. In your request for a validate, what has gone wrong in the past that you are looking for validation of? |
We have a dedicated git repository containing the AWS nuke configuration and the CI pipeline configuration for running it nightly on the sandbox accounts. This repository only gets changes via PR. We need the PR checks to do some checks on the changes, and so far we just have a YAML linter. Ideally this would run a dry-run, but that would imply giving some AWS permissions on non- The middle ground for this would be to at least validate that there are no schema errors in the aws-nuke configuration. Any issues in the filters can be resolved in a subsequent PR. |
Try the As for validating the configuration. What sort of errors have you run into the past? Trying to figure out what sort of validation you want. I'm not really sure what sort of validation could be done other than are all the resource names under Filters valid. |
@madpipeline please check out the fork of aws-nuke and it's explain-config command, if there is additional functionality you are looking for please open an issue over on the fork. Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information. Caution This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke. |
When running aws-nuke on sandbox accounts via CI tools, it would be useful to be able to validate the configuration directly, without requiring to be logged into an AWS account. Basically just make sure the YAML schema is valid.
This already happens on every run of aws-nuke by default, but it requires and AWS session, thus we cannot validate it in PR checks, where AWS accounts access is limited.
The text was updated successfully, but these errors were encountered: