Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Multus installation to use daemonset-style installation #245

Open
dougbtv opened this issue Aug 8, 2018 · 0 comments
Open

Upgrade Multus installation to use daemonset-style installation #245

dougbtv opened this issue Aug 8, 2018 · 0 comments
Assignees
@dougbtv
Labels
priority:medium type:enhancement

Comments

@dougbtv
Copy link
Member

dougbtv commented Aug 8, 2018

Multus can use a daemonset to install now. We should add this as the default way that Multus is installed, however, I don't believe we should strip out the compilation method, as sometimes during development it's not so bad to have these playbooks build Multus for you.
@dougbtv dougbtv self-assigned this Aug 8, 2018
s1061123 added a commit to s1061123/kube-ansible that referenced this issue Dec 27, 2018
@s1061123
Simplify Multus install options
b586fa3 
To address redhat-nfvpe#245 and redhat-nfvpe#258, this change fixes followings:
 + rename multus_npwg_demo to multus-2nics
 + make multus_use_crd default
 + add multus_build flag
   (if no/false, use daemonset yaml in github/multus)
 + unsupport legacy multus version
 + add docker_install_suppress_newgrp for latest ansible
 + fix daemonset yaml to support latest k8s
 + fix several build script (e.g. sr-iov cni)

Verified it under following combinations:
 + pod_network_type=none
 + pod_network_type=multus
 + pod_network_type=multus + multus_build=true
 + pod_network_type=none + multus_build=true
 + pod_network_type=multus-2nics
 + pod_network_type=multus-2nics + multus_build=true
@s1061123 s1061123 mentioned this issue Dec 27, 2018
Merged
s1061123 added a commit to s1061123/kube-ansible that referenced this issue Dec 27, 2018
@s1061123
Simplify Multus install options
be9fabb 
To address redhat-nfvpe#245 and redhat-nfvpe#258, this change fixes followings:
 + rename multus_npwg_demo to multus-2nics
 + make multus_use_crd default
 + add multus_build flag
   (if no/false, use daemonset yaml in github/multus)
 + unsupport legacy multus version
 + add docker_install_suppress_newgrp for latest ansible
 + fix daemonset yaml to support latest k8s
 + fix several build script (e.g. sr-iov cni)

Verified it under following combinations:
 + pod_network_type=none
 + pod_network_type=multus
 + pod_network_type=multus + multus_build=true
 + pod_network_type=none + multus_build=true
 + pod_network_type=multus-2nics
 + pod_network_type=multus-2nics + multus_build=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougbtv dougbtv

Labels
priority:medium type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dougbtv