Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loggers and add lifecycle events for jobs #2

Closed
Salakar opened this issue Aug 24, 2016 · 1 comment
Closed

Remove loggers and add lifecycle events for jobs #2

Salakar opened this issue Aug 24, 2016 · 1 comment

Comments

@Salakar
Copy link
Member

Salakar commented Aug 24, 2016

At the moment we've added logging for processes running in Kubernetes pods everywhere, for creation, completion and failures of jobs. Instead this should be down to the user to add - to do this we need to add in lifecycle events for jobs, I propose the following:

  • beforeCreate
    • async with callback - return original job or modified job.
  • afterCreate
    • Just plain events, no interaction with jobs.
  • onSuccess
    • Just plain events, no interaction with jobs.
  • onRelayCancelled
    • Just plain events, no interaction with jobs.
  • onRetry
    • Just plain events, no interaction with jobs.
  • onFailure
    • Just plain events, no interaction with jobs.
@Salakar Salakar added this to the v2.0.0 milestone Aug 24, 2016
@Ehesp Ehesp self-assigned this Oct 7, 2016
@Ehesp
Copy link
Member

Ehesp commented Oct 7, 2016

Hook lifecycle events:

  • beforeCreate
  • afterCreate
  • onJobSuccess
  • onJobFailure
  • onRelayStepSuccess
  • onRelayStepCancelled
  • onJobRetry

Job events:

  • onSuccess
  • onFailure
  • onRetry
  • onRelayStepSuccess
  • onRelayStepCancelled

@Ehesp Ehesp closed this as completed Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants