Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA: Benthos V3 is Inbound #270

Closed
Jeffail opened this issue Sep 4, 2019 · 2 comments
Closed

PSA: Benthos V3 is Inbound #270

Jeffail opened this issue Sep 4, 2019 · 2 comments
Labels
PSA Public Service Announcement v3 An issue proposed for V3 of Benthos

Comments

@Jeffail
Copy link
Collaborator

Jeffail commented Sep 4, 2019

Hey all, with Go 1.13 out there was a change to add more version validation when pulling dependencies with modules: https://tip.golang.org/doc/go1.13#version-validation, the important part specifically is:

The +incompatible version annotation bypasses the requirement of semantic import versioning for repositories that predate the introduction of modules. The go command now verifies that such a version does not include an explicit go.mod file.

Benthos up until now has been using modules for it's own dependencies (and therefore has a go.mod file) but also has a major version beyond 1 without adding it to the import path. The reason for this was originally because it allowed users importing Benthos through non-module methods to continue, and modules users could continue with a pseudo-version import. More info about this questionable choice of mine can be found here: #232 (comment)

However, Go 1.13 has forced me to choose one (I'm not a fan of copy/pasting the entire codebase into a /v3 subdirectory, sue me.) My plan was always to upgrade Benthos to V3 at the same time and enforce modules from that point onwards, so that's what I'm working on right now.

The migration guide outlines all the upcoming changes: https://github.com/Jeffail/benthos/blob/master/docs/migration/v3.md

Working off a branch at: https://github.com/Jeffail/benthos/tree/v3

@Jeffail Jeffail added PSA Public Service Announcement v3 An issue proposed for V3 of Benthos labels Sep 4, 2019
@Jeffail
Copy link
Collaborator Author

Jeffail commented Sep 8, 2019

Release candidates are coming in: https://github.com/Jeffail/benthos/releases

@Jeffail
Copy link
Collaborator Author

Jeffail commented Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PSA Public Service Announcement v3 An issue proposed for V3 of Benthos
Projects
None yet
Development

No branches or pull requests

1 participant