Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definition #98

Closed
arusakov opened this issue Sep 7, 2015 · 5 comments
Closed

TypeScript definition #98

arusakov opened this issue Sep 7, 2015 · 5 comments

Comments

@arusakov
Copy link

arusakov commented Sep 7, 2015

I have seen draft of .d.ts file there. But only redux.d.ts file was included to DefinitelyTyped repo.
react-redux.d.ts will be very helpful!

@pdeva
Copy link

pdeva commented Sep 13, 2015

+1
a .tsd file is really needed

@gnoff
Copy link
Contributor

gnoff commented Sep 13, 2015

PRs are always welcome. I don't use TS, don't think @gaearon does either. Hopefully someone out there using it will contribute

@gaearon
Copy link
Contributor

gaearon commented Sep 16, 2015

I'll close because we don't intend to provide or support an official definition.
Please feel free to submit a PR to DefinitelyTyped yourself!

@gaearon gaearon closed this as completed Sep 16, 2015
@thomasboyt
Copy link

@gaearon Any thoughts on reopening this now that Redux has an official definition?

There's a really nasty issue right now where the DefinitelyTyped react-redux definition doesn't actually work correctly with the officially-maintained Redux definition, only the DT Redux definition. It'd be nice if there was an official definition for react-redux that was kept in sync with the official Redux definition :)

@gaearon
Copy link
Contributor

gaearon commented May 22, 2016

Happy to accept a PR adding a definition. I just can't create one myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants