Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

orphan runtime process #9

Open
refs opened this issue Jan 5, 2021 · 4 comments
Open

orphan runtime process #9

refs opened this issue Jan 5, 2021 · 4 comments

Comments

@refs
Copy link
Owner

refs commented Jan 5, 2021

There are cases where the runtime stays running in the background, see owncloud/ocis#1173

Panic should NOT be an option.

@labkode
Copy link

labkode commented Jan 20, 2021

@refs any progress on this?

@refs
Copy link
Owner Author

refs commented Jan 20, 2021

yes, only local at the moment. Will push my branch tomorrow and add a few fixes along the way.

@refs
Copy link
Owner Author

refs commented Jan 21, 2021

@labkode a wip: #10

@refs
Copy link
Owner Author

refs commented Jan 21, 2021

I intend to get this in and hopefully get it in before the next update. You could already try this runtime in ocis by applying this diff on ocis master:

diff --git a/ocis/go.mod b/ocis/go.mod
index eddcdcb1..92fb0bc5 100644
--- a/ocis/go.mod
+++ b/ocis/go.mod
@@ -39,6 +39,7 @@ require (
 
 replace (
 	github.com/gomodule/redigo => github.com/gomodule/redigo v1.8.2
+	github.com/refs/pman => ../../../refs/pman
 	github.com/owncloud/ocis/accounts => ../accounts
 	github.com/owncloud/ocis/glauth => ../glauth
 	github.com/owncloud/ocis/konnectd => ../konnectd
diff --git a/ocis/pkg/runtime/runtime.go b/ocis/pkg/runtime/runtime.go
index de5061a4..c7187c1c 100644
--- a/ocis/pkg/runtime/runtime.go
+++ b/ocis/pkg/runtime/runtime.go
@@ -83,7 +83,7 @@ func (r *Runtime) Start() error {
 	return service.Start()
 }
 
-// Launch ocis default ocis extensions.
+// Launch ocis default extensions.
 func (r *Runtime) Launch() {
 	var client *rpc.Client
 	var err error

please note that the path is relative to my machine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants