[Bug]: type defs on NavLink broken, Property 'children' is missing in type but required in type 'NavLinkProps'.

[rtmann]

What version of React Router are you using?

6.2.2

Steps to Reproduce

• Install react router and react router-dom 6.2.2 in a typescript project
• Try to use a <NavLink from react router dom without any children.

Typescript expects NavLink to have an attribute called children set and is required. React expects children attributes to be passed as child nodes. The attribute isn't optional and can't be omitted without TS errors.

Expected Behavior

<NavLink to={'somelink'} />

Should work without any children or specifying a children attribute.

Actual Behavior

Error in typescript:

Property 'children' is missing in type '{ to: string; className: string; }' but required in type 'NavLinkProps'

[MichaelDimmitt]

reading up on this adding a few links as I go
#8164

[timdorr]

Should be as simple as making this optional:

react-router/packages/react-router-dom/index.tsx

Line 293 in 1100224

children:

Can you submit a PR?

[rtmann]

Can you submit a PR?

Done: #8725

It says I need a maintainer. Added my name to contributors (signed the agreement).